backedn converted to ts

routers/api/auth.ts

@@ -1,22 +1,34 @@
-const express = require("express");
+import express from 'express'
+import bcrypt from 'bcryptjs'
+import jwt from 'jsonwebtoken';
+
+import auth from '../../middleware/auth'
+import config from 'config'
+import { check, validationResult } from "express-validator";
+
+import User from '../../models/User'
+import type { Request, Response } from 'express';
+import { isUserId } from '../../utils';
+
 const router = express.Router();
-const bcrypt = require("bcryptjs");
-const auth = require("../../middleware/auth");
-const jwt = require("jsonwebtoken");
-const config = require("config");
-const { check, validationResult } = require("express-validator");
-
-const User = require("../../models/User");
-
 // @route    GET api/auth
 // @desc     Get user by token
 // @access   Private
-router.get("/", auth, async (req, res) => {
+router.get("/", auth, async (req: Request, res) => {
   try {
-    const user = await User.findById(req.user.id).select("-password");
-    res.json(user);
-  } catch (err) {
-    console.error(err.message);
+    let user: unknown = null
+    if (isUserId(req)) {
+      user = await User.findById(req.user.id).select("-password");
+      res.json(user);
+    }
+    else {
+      throw new Error('missing id in request')
+    }
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send("Server Error");
   }
 });
@@ -30,7 +42,7 @@ router.post(
     check("email", "Please include a valid email").isEmail(),
     check("password", "Password is required").exists(),
   ],
-  async (req, res) => {
+  async (req: Request, res: Response) => {
     const errors = validationResult(req);
     if (!errors.isEmpty()) {
       return res.status(400).json({ errors: errors.array() });
@@ -60,21 +72,25 @@ router.post(
           id: user.id,
         },
       };
-
-      jwt.sign(
+      const jwtSecret = config.get('jwtSecret')
+      if (typeof jwtSecret === 'string') jwt.sign(
         payload,
-        config.get("jwtSecret"),
+        jwtSecret,
         { expiresIn: 360000 },
         (err, token) => {
           if (err) throw err;
           res.json({ token });
         }
       );
-    } catch (err) {
-      console.error(err.message);
+      else throw new Error('Error signing the jwt token')
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send("Server error");
     }
   }
 );
 
-module.exports = router;
+module.exports = router

routers/api/posts.ts

@@ -1,11 +1,14 @@
-const express = require("express");
-const router = express.Router();
-const { check, validationResult } = require("express-validator");
-const auth = require("../../middleware/auth");
 
-const Post = require("../../models/Post");
-const User = require("../../models/User");
-const checkObjectId = require("../../middleware/checkObjectId");
+import express, { Request, Response } from 'express'
+import { check, validationResult } from "express-validator";
+import auth from "../../middleware/auth";
+import Post from "../../models/Post";
+import User from "../../models/User";
+import checkObjectId from "../../middleware/checkObjectId";
+import { isUserId } from '../../utils';
+
+
+const router = express.Router();
 
 // @route    POST api/posts
 // @desc     Create a post
@@ -22,20 +25,30 @@ router.post(
     }
 
     try {
-      const user = await User.findById(req.user.id).select("-password");
-
-      const newPost = new Post({
-        text: req.body.text,
-        name: user.name,
-        avatar: user.avatar,
-        user: req.user.id,
-      });
-
-      const post = await newPost.save();
-
-      res.json(post);
-    } catch (err) {
-      console.error(err.message);
+      if (isUserId(req)) {
+        const user = await User.findById(req.user.id).select("-password");
+        if (user) {
+          const newPost = new Post({
+            text: req.body.text,
+            name: user.name,
+            avatar: user.avatar,
+            user: req.user.id,
+          });
+          const post = await newPost.save();
+          res.json(post);
+        }
+        else {
+          throw new Error('Error finding the user')
+        }
+      }
+      else {
+        throw new Error('Error finding the user')
+      }
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send("Server Error");
     }
   }
@@ -48,8 +61,11 @@ router.get("/", auth, async (req, res) => {
   try {
     const posts = await Post.find().sort({ date: -1 });
     res.json(posts);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send("Server Error");
   }
 });
@@ -66,8 +82,11 @@ router.get("/:id", auth, checkObjectId("id"), async (req, res) => {
     }
 
     res.json(post);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
 
     res.status(500).send("Server Error");
   }
@@ -76,25 +95,32 @@ router.get("/:id", auth, checkObjectId("id"), async (req, res) => {
 // @route    DELETE api/posts/:id
 // @desc     Delete a post
 // @access   Private
-router.delete("/:id", [auth, checkObjectId("id")], async (req, res) => {
+router.delete("/:id", [auth, checkObjectId("id")], async (req: Request, res: Response) => {
   try {
-    const post = await Post.findById(req.params.id);
+    const post = await Post.findOne({ _id: req.params.id });
 
     if (!post) {
       return res.status(404).json({ msg: "Post not found" });
     }
 
     // Check user
-    if (post.user.toString() !== req.user.id) {
-      return res.status(401).json({ msg: "User not authorized" });
+    if (post.user && isUserId(req)) {
+      if (post.user.toString() !== req.user.id) {
+        return res.status(401).json({ msg: "User not authorized" });
+      }
     }
-
-    await post.remove();
+    else {
+      throw new Error('Error in req.user')
+    }
+    await post.deleteOne();
 
     res.json({ msg: "Post removed" });
-  } catch (err) {
-    console.error(err.message);
 
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send("Server Error");
   }
 });
@@ -107,17 +133,24 @@ router.put("/like/:id", auth, checkObjectId("id"), async (req, res) => {
     const post = await Post.findById(req.params.id);
 
     // Check if the post has already been liked
-    if (post.likes.some((like) => like.user.toString() === req.user.id)) {
-      return res.status(400).json({ msg: "Post already liked" });
-    }
+    if (post && isUserId(req)) {
+      if (post.likes.some((like) => like.user?.toString() === req.user.id)) {
+        return res.status(400).json({ msg: "Post already liked" });
+      }
 
-    post.likes.unshift({ user: req.user.id });
+      const user: any = req.user.id
+      // can't make string into ObjectID
+      post.likes.unshift({ user });
 
-    await post.save();
+      await post.save();
 
-    return res.json(post.likes);
-  } catch (err) {
-    console.error(err.message);
+      return res.json(post.likes)
+    };
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send("Server Error");
   }
 });
@@ -130,20 +163,30 @@ router.put("/unlike/:id", auth, checkObjectId("id"), async (req, res) => {
     const post = await Post.findById(req.params.id);
 
     // Check if the post has not yet been liked
-    if (!post.likes.some((like) => like.user.toString() === req.user.id)) {
-      return res.status(400).json({ msg: "Post has not yet been liked" });
+    if (post && isUserId(req)) {
+
+      if (!post.likes.some((like) => like.user?.toString() === req.user.id)) {
+        return res.status(400).json({ msg: "Post has not yet been liked" });
+      }
+
+      // remove the like
+      post.likes = post.likes.filter(
+        ({ user }) => {
+          if (user)
+            return user.toString() !== req.user.id
+          return false
+        }
+      );
+
+      await post.save();
+
+      return res.json(post.likes);
     }
-
-    // remove the like
-    post.likes = post.likes.filter(
-      ({ user }) => user.toString() !== req.user.id
-    );
-
-    await post.save();
-
-    return res.json(post.likes);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send("Server Error");
   }
 });
@@ -163,23 +206,31 @@ router.post(
     }
 
     try {
-      const user = await User.findById(req.user.id).select("-password");
-      const post = await Post.findById(req.params.id);
-
-      const newComment = {
-        text: req.body.text,
-        name: user.name,
-        avatar: user.avatar,
-        user: req.user.id,
-      };
-
-      post.comments.unshift(newComment);
-
-      await post.save();
-
-      res.json(post.comments);
-    } catch (err) {
-      console.error(err.message);
+      if (isUserId(req) && req.params) {
+        const user = await User.findById(req.user.id).select("-password");
+        const post = await Post.findById(req.params.id);
+        if (user) {
+          const newComment = {
+            text: req.body.text,
+            name: user.name,
+            avatar: user.avatar,
+            user: req.user.id,
+          };
+          if (post) {
+            post.comments.unshift(newComment as any);
+            await post.save();
+            res.json(post.comments);
+          }
+          throw new Error('Error in finding post')
+        }
+        throw new Error('Error in finding user')
+      }
+      throw new Error('Error in parsing the req')
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send("Server Error");
     }
   }
@@ -193,29 +244,34 @@ router.delete("/comment/:id/:comment_id", auth, async (req, res) => {
     const post = await Post.findById(req.params.id);
 
     // Pull out comment
-    const comment = post.comments.find(
-      (comment) => comment.id === req.params.comment_id
-    );
-    // Make sure comment exists
-    if (!comment) {
-      return res.status(404).json({ msg: "Comment does not exist" });
+    if (post) {
+      const comment = post.comments.find(
+        (comment: any) => comment.id === req.params.comment_id
+      );
+      // Make sure comment exists
+      if (!comment) {
+        return res.status(404).json({ msg: "Comment does not exist" });
+      }
+      // Check user
+      if ('user' in comment && comment.user && isUserId(req) && comment.user.toString() !== req.user.id) {
+        return res.status(401).json({ msg: "User not authorized" });
+      }
+
+      post.comments = post.comments.filter(
+        ({ id }: any) => id !== req.params.comment_id
+      );
+
+      await post.save();
+
+      return res.json(post.comments);
     }
-    // Check user
-    if (comment.user.toString() !== req.user.id) {
-      return res.status(401).json({ msg: "User not authorized" });
-    }
-
-    post.comments = post.comments.filter(
-      ({ id }) => id !== req.params.comment_id
-    );
-
-    await post.save();
-
-    return res.json(post.comments);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     return res.status(500).send("Server Error");
   }
 });
 
-module.exports = router;
+module.exports = router

routers/api/profile.ts

@@ -1,32 +1,40 @@
-const express = require('express');
-const axios = require('axios');
-const config = require('config');
-const router = express.Router();
-const auth = require('../../middleware/auth');
-const { check, validationResult } = require('express-validator');
-// bring in normalize to give us a proper url, regardless of what user entered
-const normalize = require('normalize-url');
-const checkObjectId = require('../../middleware/checkObjectId');
+import express from 'express';
+import axios from 'axios';
+import config from 'config';
 
-const Profile = require('../../models/Profile');
-const User = require('../../models/User');
-const Post = require('../../models/Post');
+import auth from '../../middleware/auth';
+import { check, validationResult } from 'express-validator';
+
+// bring in normalize to give us a proper url, regardless of what user entered
+import normalize from 'normalize-url';
+import checkObjectId from '../../middleware/checkObjectId';
+
+import Profile from '../../models/Profile';
+import User from '../../models/User';
+import Post from '../../models/Post';
+import { isUserId } from '../../utils';
+const router = express.Router();
 // @route    GET api/profile/me
 // @desc     Get current users profile
 // @access   Private
 router.get('/me', auth, async (req, res) => {
   try {
-    const profile = await Profile.findOne({
-      user: req.user.id
-    }).populate('user', ['name', 'avatar']);
+    if (isUserId(req)) {
+      const profile = await Profile.findOne({
+        user: req.user.id
+      }).populate('user', ['name', 'avatar']);
 
-    if (!profile) {
-      return res.status(400).json({ msg: 'There is no profile for this user' });
+      if (!profile) {
+        return res.status(400).json({ msg: 'There is no profile for this user' });
+      }
+
+      res.json(profile);
     }
-
-    res.json(profile);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send('Server Error');
   }
 });
@@ -59,40 +67,45 @@ router.post(
     } = req.body;
 
     // build a profile
-    const profileFields = {
-      user: req.user.id,
-      website:
-        website && website !== ''
-          ? normalize(website, { forceHttps: true })
-          : '',
-      skills: Array.isArray(skills)
-        ? skills
-        : skills.split(',').map((skill) => ' ' + skill.trim()),
-      ...rest
-    };
+    if (isUserId(req)) {
+      const profileFields = {
+        user: req.user.id,
+        website:
+          website && website !== ''
+            ? normalize(website, { forceHttps: true })
+            : '',
+        skills: Array.isArray(skills)
+          ? skills
+          : skills.split(',').map((skill: string) => ' ' + skill.trim()),
+        ...rest
+      };
 
-    // Build socialFields object
-    const socialFields = { youtube, twitter, instagram, linkedin, facebook };
+      // Build socialFields object
+      const socialFields: { [key: string]: any } = { youtube, twitter, instagram, linkedin, facebook };
 
-    // normalize social fields to ensure valid url
-    for (const [key, value] of Object.entries(socialFields)) {
-      if (value && value.length > 0)
-        socialFields[key] = normalize(value, { forceHttps: true });
-    }
-    // add to profileFields
-    profileFields.social = socialFields;
+      // normalize social fields to ensure valid url
+      for (const [key, value] of Object.entries(socialFields)) {
+        if (value && value.length > 0)
+          socialFields[key] = normalize(value, { forceHttps: true });
+      }
+      // add to profileFields
+      profileFields.social = socialFields;
 
-    try {
-      // Using upsert option (creates new doc if no match is found):
-      let profile = await Profile.findOneAndUpdate(
-        { user: req.user.id },
-        { $set: profileFields },
-        { new: true, upsert: true, setDefaultsOnInsert: true }
-      );
-      return res.json(profile);
-    } catch (err) {
-      console.error(err.message);
-      return res.status(500).send('Server Error');
+      try {
+        // Using upsert option (creates new doc if no match is found):
+        let profile = await Profile.findOneAndUpdate(
+          { user: req.user.id },
+          { $set: profileFields },
+          { new: true, upsert: true, setDefaultsOnInsert: true }
+        );
+        return res.json(profile);
+      } catch (err: unknown) {
+        if (typeof err === 'string')
+          console.error(err)
+        else if (err instanceof Error)
+          console.error(err.message);
+        return res.status(500).send('Server Error');
+      }
     }
   }
 );
@@ -104,8 +117,11 @@ router.get('/', async (req, res) => {
   try {
     const profiles = await Profile.find().populate('user', ['name', 'avatar']);
     res.json(profiles);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send('Server Error');
   }
 });
@@ -125,8 +141,11 @@ router.get(
       if (!profile) return res.status(400).json({ msg: 'Profile not found' });
 
       return res.json(profile);
-    } catch (err) {
-      console.error(err.message);
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       return res.status(500).json({ msg: 'Server error' });
     }
   }
@@ -140,15 +159,19 @@ router.delete('/', auth, async (req, res) => {
     // Remove user posts
     // Remove profile
     // Remove user
-    await Promise.all([
-      Post.deleteMany({ user: req.user.id }),
-      Profile.findOneAndRemove({ user: req.user.id }),
-      User.findOneAndRemove({ _id: req.user.id })
-    ]);
+    if (isUserId(req))
+      await Promise.all([
+        Post.deleteMany({ user: req.user.id }),
+        Profile.findOneAndRemove({ user: req.user.id }),
+        User.findOneAndRemove({ _id: req.user.id })
+      ]);
 
     res.json({ msg: 'User deleted' });
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     res.status(500).send('Server Error');
   }
 });
@@ -171,15 +194,21 @@ router.put(
     }
 
     try {
-      const profile = await Profile.findOne({ user: req.user.id });
+      if (isUserId(req)) {
+        const profile = await Profile.findOne({ user: req.user.id });
 
-      profile.experience.unshift(req.body);
+        if (profile) {
+          profile.experience.unshift(req.body);
 
-      await profile.save();
-
-      res.json(profile);
-    } catch (err) {
-      console.error(err.message);
+          await profile.save();
+        }
+        res.json(profile);
+      }
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send('Server Error');
     }
   }
@@ -191,16 +220,22 @@ router.put(
 
 router.delete('/experience/:exp_id', auth, async (req, res) => {
   try {
-    const foundProfile = await Profile.findOne({ user: req.user.id });
+    if (isUserId(req)) {
+      const foundProfile = await Profile.findOne({ user: req.user.id });
+      if (foundProfile) {
+        foundProfile.experience = foundProfile.experience.filter(
+          (exp: any) => exp._id.toString() !== req.params.exp_id
+        );
 
-    foundProfile.experience = foundProfile.experience.filter(
-      (exp) => exp._id.toString() !== req.params.exp_id
-    );
-
-    await foundProfile.save();
-    return res.status(200).json(foundProfile);
-  } catch (error) {
-    console.error(error);
+        await foundProfile.save();
+      }
+      return res.status(200).json(foundProfile);
+    }
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     return res.status(500).json({ msg: 'Server error' });
   }
 });
@@ -224,15 +259,20 @@ router.put(
     }
 
     try {
-      const profile = await Profile.findOne({ user: req.user.id });
+      if (isUserId(req)) {
+        const profile = await Profile.findOne({ user: req.user.id });
+        if (profile) {
+          profile.education.unshift(req.body);
 
-      profile.education.unshift(req.body);
-
-      await profile.save();
-
-      res.json(profile);
-    } catch (err) {
-      console.error(err.message);
+          await profile.save();
+        }
+        res.json(profile);
+      }
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send('Server Error');
     }
   }
@@ -244,14 +284,21 @@ router.put(
 
 router.delete('/education/:edu_id', auth, async (req, res) => {
   try {
-    const foundProfile = await Profile.findOne({ user: req.user.id });
-    foundProfile.education = foundProfile.education.filter(
-      (edu) => edu._id.toString() !== req.params.edu_id
-    );
-    await foundProfile.save();
-    return res.status(200).json(foundProfile);
-  } catch (error) {
-    console.error(error);
+    if (isUserId(req)) {
+      const foundProfile = await Profile.findOne({ user: req.user.id });
+      if (foundProfile) {
+        foundProfile.education = foundProfile.education.filter(
+          (edu: any) => edu._id.toString() !== req.params.edu_id
+        );
+        await foundProfile.save();
+      }
+      return res.status(200).json(foundProfile);
+    }
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     return res.status(500).json({ msg: 'Server error' });
   }
 });
@@ -271,10 +318,13 @@ router.get('/github/:username', async (req, res) => {
 
     const gitHubResponse = await axios.get(uri, { headers });
     return res.json(gitHubResponse.data);
-  } catch (err) {
-    console.error(err.message);
+  } catch (err: unknown) {
+    if (typeof err === 'string')
+      console.error(err)
+    else if (err instanceof Error)
+      console.error(err.message);
     return res.status(404).json({ msg: 'No Github profile found' });
   }
 });
 
-module.exports = router;
+module.exports = router

routers/api/users.ts

@@ -1,12 +1,15 @@
-const express = require("express");
+import express from "express";
+import gravatar from "gravatar";
+import bcrypt from "bcryptjs";
+import jwt from "jsonwebtoken";
+import config from "config";
+import { check, validationResult } from "express-validator";
+import User from "../../models/User";
+
+import normalizeUrl from "normalize-url";
+
+
 const router = express.Router();
-const gravatar = require("gravatar");
-const bcrypt = require("bcryptjs");
-const jwt = require("jsonwebtoken");
-const config = require("config");
-const { check, validationResult } = require("express-validator");
-const User = require("../../models/User");
-const normalize = require('normalize-url');
 
 // @route    POST api/users
 // @desc     Register user
@@ -36,7 +39,7 @@ router.post(
           .json({ errors: [{ msg: "User already exists" }] });
       }
 
-      const avatar = normalize(
+      const avatar = normalizeUrl(
         gravatar.url(email, {
           s: "200",
           r: "pg",
@@ -64,20 +67,24 @@ router.post(
         },
       };
 
-      jwt.sign(
+      const jwtSecret = config.get('jwtSecret')
+      if (typeof jwtSecret === 'string') jwt.sign(
         payload,
-        config.get("jwtSecret"),
+        jwtSecret,
         { expiresIn: "5 days" },
         (err, token) => {
           if (err) throw err;
           res.json({ token });
         }
       );
-    } catch (err) {
-      console.error(err.message);
+    } catch (err: unknown) {
+      if (typeof err === 'string')
+        console.error(err)
+      else if (err instanceof Error)
+        console.error(err.message);
       res.status(500).send("Server error");
     }
   }
 );
 
-module.exports = router;
+module.exports = router